Unused argument `dir_create` inside `use_{internal,external}_XXX_file()` function family[BUG] - Githubissues

ThinkR-open / golem

A Framework for Building Robust Shiny Apps

https://thinkr-open.github.io/golem/

Other

908 stars 132 forks source link

Unused argument `dir_create` inside `use_{internal,external}_XXX_file()` function family[BUG] #1061

Closed ilyaZar closed 1 year ago

ilyaZar commented 1 year ago

Describe the bug Possibly redundant argument dir_create (which defaults to TRUE everywhere). Maybe I am mistaken, but I cannot figure out if it is used anywhere.

Since there is the dir_created <- create_if_needed(...) dance it is most likely redundant, or?

Can take care of this inside #1059 . My suggestion would be to simply remove this function argument.

edit: I am relating to the functions inside R/use_files.R

ilyaZar commented 1 year ago

Closed via #1059 #1082