search

ThinkR-open / golem

A Framework for Building Robust Shiny Apps
https://thinkr-open.github.io/golem/
Other
885 stars 130 forks source link

Fix 1031 #1063

Closed ilyaZar closed 8 months ago

ilyaZar commented 1 year ago

Fix #1031

Just to make sure I do not miss anything @jdavis-EliLilly , is it just this one-liner here? https://github.com/ThinkR-open/golem/blob/1ce2d5c28f287c2da08a6358c8160d88e8c46af1/inst/shinyexample/dev/03_deploy.R#L40-L42

From the documentation I understand that rsconnect::writeManifest() is for repeated usage, similar to rsconnect::deployApp() for repeated deployment (whereas the other functions in the file are usually called once for file creation only). So I would think this is a reasonable place for the rsconnect::writeManifest() call, or?

ColinFay commented 8 months ago

I've cherry-picked and merged to https://github.com/ThinkR-open/golem/tree/1063-cherry-picked