ThinkR-open / golem

A Framework for Building Robust Shiny Apps
https://thinkr-open.github.io/golem/
Other
885 stars 130 forks source link

hotfix: fix path construction to pass CI on `MAC-OS` for `Dev-1077` #1084

Closed ilyaZar closed 11 months ago

ilyaZar commented 11 months ago

Issue:

The current Dev-PR #1077 cannot pass the CI because of incorrect path construction on Mac-OS inside the tests/testthat/test-config.R for some of the tests.

Fix:

Add a helper for path construction (for any subdir given some top-dir name of a {golem} package). Might be useful for other similar test-cases when subdirs on Mac-OS are needed; hence the helper-function is put inside tests/helper-config.R.

VincentGuyader commented 11 months ago

I had actually sent a message to the Mac users at Thinkr to help me with this last night. Thank you very much.

ilyaZar commented 11 months ago

yes @VincentGuyader sorry for causing the trouble I should have checked my implemented tests earlier...