search

ThinkR-open / golem

A Framework for Building Robust Shiny Apps
https://thinkr-open.github.io/golem/
Other
885 stars 130 forks source link

[FR] Improved fix for broken test `test-use_readme.R` #1121

Open ilyaZar opened 7 months ago

ilyaZar commented 7 months ago

Via https://github.com/ThinkR-open/golem/commit/9ad97753a585ca1ec418025f3ff08db629592702 a test fix for test-use_readme() is done that skips the test in non-interactive mode.

However, when eliminating the devtools:::build_readme() call at the very end, the test passes successfully in non-interactive mode, so no need for skipping.

Hence, to improve codecov one may delete the devtools:::build_readme() line and run the test as usual.

Can be fixed via #1122