search

ThinkUpLLC / ThinkUp

ThinkUp gives you insights into your social networking activity on Twitter, Facebook, Instagram, and beyond.
http://thinkup.com
GNU General Public License v3.0
3.3k stars 674 forks source link

Migrate to Smarty 3 #2048

Open paazmaya opened 10 years ago

paazmaya commented 10 years ago

Smarty 3 has been out since 2010. It's time to upgrade ThinkUp. http://smarty-php.googlecode.com/svn/trunk/distribution/SMARTY_2_BC_NOTES.txt

Ramoonus commented 10 years ago

what version of php are you using?

paazmaya commented 10 years ago

Might have been the latest 5.4 available at that time....

sarcas commented 10 years ago

Ah, I hit this today as well (when playing around with the thinkup.com branch). The deprecation is a PHP 5.5 issue (see the Changelog on preg_replace).

Rather than forcing and update to Smarty 3, it looks like the Smarty project recently released an update, version 2.6.28, which resolves the warnings.

I've got a branch together that updates the Smarty version, so hopefully I can get this updated soon.

paazmaya commented 10 years ago

Great @sarcas !

ginatrapani commented 9 years ago

Thanks again to @sarcas for updating the Smarty 2.6 version; that is now merged into master. However, I am going to keep this ticket open because I'd like to upgrade to Smarty 3 at some point (hopefully soon).

paazmaya commented 9 years ago

That is also great! @ginatrapani

paazmaya commented 9 years ago

Just happened to come across this http://tech.blog.box.com/2014/09/box-open-source-introducing-brainy/ Not sure how easily to jump over in using the given fork and also not sure if the performance benefit will be similar with ThinkUp...