search

ThinkUpLLC / ThinkUp

ThinkUp gives you insights into your social networking activity on Twitter, Facebook, Instagram, and beyond.
http://thinkup.com
GNU General Public License v3.0
3.3k stars 674 forks source link

Unit Test for New Dictionary Words Insight is Broken #2238

Closed sarcas closed 9 years ago

sarcas commented 9 years ago

Reproduce Check out a copy of master. Run the test suite for NewDictionaryWords:

php ./webapp/plugins/insightsgenerator/tests/TestOfNewDictionaryWordsInsight.php

Expected Result All tests should pass

Actual Result The testTwoMatches test fails.

It turns out the failure is because of the three Matches tests in the test class, testTwoMatches is using a hard coded date August 2013, and the test is set up to use dates relative to the date the test is run.

The other two tests get around this by using a relative date in the comparison string.

ginatrapani commented 9 years ago

Fixed in 1a3d9d65662baf0912b048b9db1c675d40d660d4