search

ThinkUpLLC / ThinkUp

ThinkUp gives you insights into your social networking activity on Twitter, Facebook, Instagram, and beyond.
http://thinkup.com
GNU General Public License v3.0
3.3k stars 674 forks source link

Issue #2236 - Fixes Forgotton Passwords for self-hosting #2240

Closed sarcas closed 9 years ago

sarcas commented 9 years ago

This is a fix for https://github.com/ThinkUpLLC/ThinkUp/issues/2236

Since the ThinkUp version two redesign was merged into master, the forgotten passwords functionality for self-hosted systems has not worked. The controller had a check for the value of the submit button in order to send out the forgotten passwords template. However, the redesign changed the text (and hence the value) of the button, and the controller has never been changed to catch up.

This commit makes that change, updates the controller tests and adds an end-to-end test to catch the regression in future.

ginatrapani commented 9 years ago

Great patch, thank you for the thoroughness. Merged in a2d75c4208c993cb985a54bacd41b047a69b393f