search

Thinkful-Ed / node-jwt-auth

15 stars 118 forks source link

Review #1

Closed benjaminEwhite closed 7 years ago

benjaminEwhite commented 7 years ago

Overall, this looks good. Key will be in explanation in curriculum. Most of the comments I left are about leaving comments in code at points that won't be obvious to students.

benjaminEwhite commented 7 years ago

Also, shouldn't we have some tests ?

oampo commented 7 years ago

@benjaminEwhite I've addressed the issues, and added tests. Can you give the tests a review?