ThinkingStudios / RyoamicLights

LambDynamicLights unofficial architectury port. A dynamic lights mod for Minecraft.
MIT License
11 stars 2 forks source link

[Incompatible] Incompatible with Ars Nouveau #3

Closed JohnM514 closed 8 months ago

JohnM514 commented 9 months ago

When trying to load a world it crashes

Steps to reproduce the behavior:

  1. Open Minecraft
  2. Click on 'Singleplayer'
  3. Select a world
  4. Load the world
  5. It will state that its joining the world, the loading the terrain and right before crashing to desktop it would state that its saving the world

Expected behavior It should load the world.

Desktop (please complete the following information):

Additional context Add any other context about the problem here. crash-2023-09-28_08.53.43-client.txt

JohnM514 commented 9 months ago

After doing additional testing it seems that there is a compatibility issue with Ars Nouveau

TexBlock commented 9 months ago

After doing additional testing it seems that there is a compatibility issue with Ars Nouveau

Yes, from the code it looks like Ars Nouveau has LambDynamicLights built in?

DxsSucuk commented 9 months ago

Does this mean Ars Nouveau already contains DynamicLights? So if someone uses Ars Nouveau they dont need to use the DynamicLights mod?

TexBlock commented 9 months ago

Does this mean Ars Nouveau already contains DynamicLights? So if someone uses Ars Nouveau they dont need to use the DynamicLights mod?

Yes

DxsSucuk commented 9 months ago

Well while testing not too long ago, it looks like the light does not work on torches and such? Maybe only on the spell particals?

DxsSucuk commented 9 months ago

Nvm, figured out its completly disabled by default and needs to be enabled via the config.

TexBlock commented 9 months ago

I think the current solution is either AN removing the code about LDL or not installing RDL.

JohnM514 commented 9 months ago

It makes sense, thanks , btw searching for a replacement for RDL to use with Ars Nouveau (I did not know we could just enable Ars Nouveau DL) I found Lucent which works with Ars Nouveau

TexBlock commented 9 months ago

i will fix in NEXT VERSION

UndarkAido commented 9 months ago

If the fix was meant to be in 0.1.3+1.20.1 it doesn't seem like it worked. Not sure of the timeline, GitHub just very helpfully shows everything as "last week".

TexBlock commented 9 months ago

If the fix was meant to be in 0.1.3+1.20.1 it doesn't seem like it worked. Not sure of the timeline, GitHub just very helpfully shows everything as "last week".

AN's dynamic lights really don't work with RyoamicLights, one of the dynamic lights must be turned off for the other to take effect.

TexBlock commented 8 months ago

fixed in 0.1.5+1.20.1/0.1.4+1.19.4/0.1.4+1.19.3/0.1.4+1.19.2/0.1.4+1.18.2/0.1.5+1.16.5 again