ThinkingStudios / RyoamicLights

LambDynamicLights unofficial architectury port. A dynamic lights mod for Minecraft.
MIT License
17 stars 2 forks source link

crash on startup with spell engine mod #46

Open AnukWarrior opened 1 week ago

AnukWarrior commented 1 week ago

Describe the bug attempting to launch minecraft with spell engine and ryoamiclights crashes the game on startup

To Reproduce Steps to reproduce the behavior: 1.install ryoamiclights and its dependancys 2.install spell engine and its dependancys 3.start up minecraft 4.game crashes during boot

Expected behavior starting up minecraft with spell engine and ryoamiclights with no crash

Desktop (please complete the following information):

Additional context

i tested this on prism launcher by the way

spell engine link

https://modrinth.com/mod/spell-engine

logs

crash-2024-09-11_13.25.45-client.txt

latest.log

NattoRiisa commented 1 week ago

same bug happening on my end too

ZsoltMolnarrr commented 6 days ago

The implementation of this distribution is incorrect.

It uses the old entrypoint, defined by of LambDynamicLights, for example:

    "dynamiclights": [
      "net.spell_engine.client.compatibility.DynamicLightsCompatibility"
    ]

while expecting new package names to be used.

Old package names were:

import dev.lambdaurora.lambdynlights.api.DynamicLightHandlers;
import dev.lambdaurora.lambdynlights.api.DynamicLightsInitializer;

To handle breaking changes in a more compatible manner, it is strongly recommended for this project to rename its entrypoint, to something unique. (such as ryoamic_dynamic_lights)

The current state of this project makes it impossible to support both LambDynamicLights and SodiumDynamicLights and / RyoamicLights, forcing the code to choose. While all of these being available simultaneously for players to download.