search

Thinkmill / keystatic

First class CMS experience, TypeScript API, Markdown & YAML/JSON based, no DB
https://keystatic.com
MIT License
1.23k stars 79 forks source link

Give groups a visual border #1287

Open tordans opened 2 months ago

tordans commented 2 months ago

I want to revisit the idea to add a visual indication for groups.

(…) It lacks the prominent delineation of your example, which I'd like to revisit in the future. From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.

Originally posted by @jossmac in https://github.com/Thinkmill/keystatic/issues/641#issuecomment-1749974974

Current Proposal
current proposal

From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.

I expect the primary use case to have one group. So IMO the UI should serve this use case first. However, if deeply nested structures are in deed something that happens a lot and the border does indeed make this case noticably worse, we could add custom CSS to only show the border on the first level. Or introduce a new flag like showGrouped: true to opt into the border.

jossmac commented 2 months ago

Thanks for the reminder, @tordans! Keen to take another look at this in the near future

tordans commented 2 months ago

@jossmac happy to help once I get https://github.com/Thinkmill/keystatic/discussions/1285 or "how to get this project running locally" sorted out…