Closed maraisr closed 2 years ago
Latest commit: 8bbdb77498f858e7ce637ba23be5fb82008ada30
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Friendly bump @Andarist @mitchellhamilton
May I suggest including depcheck to avoid this in the future?
This package is built using Preconstruct and it already comes with a "variant" of the dep check, unfortunately - it only validates runtime dependencies. I think the type-only deps are kinda ignored by it. Having that improved would be a nice addition to the Preconstruct
In any case, it's a dep that sound be added to the package json. Mind helping me here?
@mitchellhamilton @Andarist dang forgot to push up a changesets, like me to PR a subsequent one?
that would be great
This package imports a type from a file not defined in the package.
https://github.com/Thinkmill/manypkg/blob/24cf58240d8312c050c17708fb0b7e8aad78d21b/packages/get-packages/src/index.ts#L9
May I suggest including
depcheck
to avoid this in the future?