search

Thinkmill / manypkg

☔️ An umbrella for your monorepo
MIT License
872 stars 48 forks source link

Allow multiple versions for external mismatch rule #131

Open cheesehary opened 2 years ago

cheesehary commented 2 years ago

https://github.com/Thinkmill/manypkg/issues/13#issuecomment-1010619075

We added an extra option to allow multiple versions for the external mismatch check. This allows to upgrade packages incrementally

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 19c91de53f6a52222ae2033295564d65a71b08e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------ | ----- | | @manypkg/cli | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

fbartho commented 2 years ago

This looks like it's the building blocks of what I'd need to implement #129 -- did I read this code correctly?

cheesehary commented 2 years ago

@fbartho Yes, the current logic is to clamp the version back to the most commonly used one if it breaks the rule. We are thinking to change it to the highest version in the allowed list by default.

Developers might want the highest allowed version most of the time. We can also save some migrations in the incremental upgrade if we install the highest version in the first place.

fbartho commented 2 years ago

That sounds great! I certainly vote for this PR and for changing the default, or adding an option.

Not sure who is a contributor/maintainer here @cheesehary! Do you think anybody from @thinkmill will approve/merge this?

cheesehary commented 2 years ago

@fbartho I'm not sure if anyone is reviewing/will approve this.