search

Thinkmill / manypkg

☔️ An umbrella for your monorepo
MIT License
872 stars 48 forks source link

Suggested fixes to tsconfig, prettier config #156

Closed elliot-nelson closed 1 year ago

elliot-nelson commented 1 year ago

SUMMARY

DETAILS

I am open to pushback on this, but I think in general, using package.json as an unstructured grab-bag is less discoverable than using tool-specific configuration files. So I was hoping to split out .prettierrc.js into its own file in the root.

It would also be nice to add prettier-plugin-packagejson -- it's very opinionated, as it wraps the opinionated sort-package-json utility, but I've found it really nice to just give in and let VSCode auto-sort my whole packagejson every time I touch it.

Last, I think we (and everyone else) should turn off useUnknownInCatchVariables. Notably, even the TypeScript codebase itself turns this off -- the extra safety is not worth the hassle until TS starts offering some better assumptions (like at least being able to specify err: Error).

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 1d8392bebfdc10002230f537eb025f4374b42277

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

elliot-nelson commented 1 year ago

^ One note -- I don't know if this is normal or not -- but it looks like this PR doesn't run CI checks at all (I'd feel a bit safer if it was actually running CI on a change like this).

Andarist commented 1 year ago

^ One note -- I don't know if this is normal or not -- but it looks like this PR doesn't run CI checks at all (I'd feel a bit safer if it was actually running CI on a change like this).

It's the whole mining prevention measure implemented by GitHub. For first-time contributors, the CI needs a maintainer's approval to run. I've approved this workflow - it should pass in a moment, I will land this and you won't have that problem again.