Closed dcousens closed 1 year ago
Latest commit: b17c1d4702638b367ca374ab00ae754010cce8fe
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@Andarist typically I wouldn't have merged this until the remaining contributors had acknowledged the pull request.
We are still waiting on @chalkpe @elliot-nelson @emmatown @evocateur @jroebu14 @maraisr @marcodejongh @NateRadebaugh @Noviny @SalimBensiali @zzarcon
I don't think I'm able to approve the change, but seems good to me, thanks!
Thanks for the approval @NateRadebaugh, you can approve any pull request on GitHub using the "Files Changed" tab, but unless you are a contributor, your approval will show up as grey not green.
@Andarist typically I wouldn't have merged this until the remaining contributors had acknowledged the pull request.
Sorry if I jumped the gun here - but I just figured out that it's OK here given "This project is relying only on the SPDX identifier for determining the governing LICENSE." and the fact that this PR has been open for a while. It's likely that we won't ever get all of those approvals.
@Andarist in my experience, the process works, it may take 3-6 months though
@elliot-nelson @maraisr @chalkpe @marcodejongh @jroebu14 @zzarcon @evocateur your acknowledgement is appreciated, but TMK not required :yellow_heart:
fine by me. 👌
Sounds good to me!
Yeah fine by me, I cant actually tiuck it anymore
This project is relying only on the SPDX identifier for determining the governing LICENSE. For the avoidance of doubt, the project should have a
LICENSE
file and reference in theREADME
.Contacting every collaborator to acknowledge and (preferably) approve this pull request