search

Thinkmill / manypkg

☔️ An umbrella for your monorepo
MIT License
891 stars 48 forks source link

Bug: `npm:x@y` doesn't work for tags #193

Closed KATT closed 8 months ago

KATT commented 8 months ago

Heya, super grateful for this lib, it keeps things tidy 🧹

In my case now, it seems to make things too tidy, where it doesn't allow me to use @tag

I added a dep in my monorepo for e.g. "@trpc/server": "npm:@trpc/server@next", (note it has a tag and not a version at the end). Manypkg does not like that.

☔️ error @examples/standalone-server has a dependency on @trpc/server@npm:@trpc/server@next but the version of @trpc/server in the repo is 10.45.0 which is not within range of the depended on version, please update the dependency version

See https://github.com/trpc/trpc/pull/5315:

CleanShot 2024-01-11 at 21 34 01@2x

Andarist commented 8 months ago

The most surprising thing for me here is that you say that it doesn't error like this with npm@trpc/server@1.2.3 😅

Fixing this should be fairly easy here. Would you perhaps want to do it? 😉

KATT commented 8 months ago

Of course you're involved in this project, @Andarist, you're fucking everywhere 😂❤️

Andarist commented 8 months ago

The path from being a user to becoming a maintainer is surprisingly short at times 😅