Add eslint - Githubissues

Thinkmill / monorepo

📦 Thinkmill's Monorepo Style Guide

https://monorepo.guide

MIT License

188 stars 5 forks source link

Add eslint #19

Closed nathsimpson closed 3 years ago

nathsimpson commented 4 years ago

Install ESLINT, and a basic GitHub Action, as well as resolve any eslint errors

Noviny commented 4 years ago

The lack of eslint was more a feature than a bug - what’s the reason for wanting to add these?

nathsimpson commented 4 years ago

@Noviny Immediate reason was for developing the website, but also for any further things we might add to this repo.

nathsimpson commented 4 years ago

This PR has been here for a while. Happy to close it if it's not wanted :)

elisechant commented 3 years ago

Hey @nathsimpson, this is great initiative, I was looking for the linter too!

It would be great if you could improve this PR by aiming for a slightly lighter touch.

What I mean by this is:

have as few eslint packages as possible
perhaps include "eslint-config-prettier" and "eslint-plugin-prettier"
remove prop-types additions
aim for a lighter .eslintrc

Potentially also:

add git hook to run format or lint on push

nathsimpson commented 3 years ago

Thanks for finding this. I hadn't seen touched this in over a year! Great suggestions, I have addressed your feedback

elisechant commented 3 years ago

@nathsimpson I just deleted the origin/website branch, can you please reopen against origin/master? You'll also need to sync with origin/master.