Thinkwise / cordova-plugin-websql

Cordova WebSQL plugin for Windows Phone
4 stars 9 forks source link

Automated install steps + new IndexedDB plugin #1

Closed JamesMessinger closed 9 years ago

JamesMessinger commented 9 years ago

Hi @DickvdBrink and @Nimrodxx. Thanks again for open-sourcing this plug-in. I've created a new IndexedDB plugin that uses this plugin instead of the MSOpenTech one. I also made a few changes to this plugin to simplify the installation process. Here are the changes I made:

  1. Added an after_plugin_install hook that takes care of modifying the .jsproj and .sln files, so now there aren't any manual post-installation steps
  2. Updated the ReadMe file to get rid of the manual installation steps, included the Cordova CLI installation command, and linked to the async IndexedDB plugin
  3. Cordova is moving all plugins to npm, so I added a package.json file and renamed the plugin according to the new naming convention (cordova-plugin-websql-async). You can publish the plugin to npm using the npm publish command. Let me know once you've done that, and I'll update the IndexedDB plugin to point to your npm package.
JamesMessinger commented 9 years ago

Just committed some more fixes.

  1. Fixed a global variable leak (idxRow)
  2. Added logic to prevent duplicate SQLite references when updating the plugin/platform
  3. Fixed a bug where clearQueue() was sometimes being called on the wrong object
DickvdBrink commented 9 years ago

Thanks! Will look at this tomorrow :) Nice fixes btw :)!

JamesMessinger commented 9 years ago

With these fixes in place, almost all of the IndexedDBShim unit tests pass on Windows Phone 8.1. Only 19 tests (out of 314) are still failing. All of the failing tests are caused by these three bugs:

optimized-screen shot 2015-04-20 at 11 40 02 am 1

DickvdBrink commented 9 years ago

@BigstickCarpet, merged by @Nimrodxx and thanks for the PR.

Need to look into the Duplicate primary keys in simultaneous transactions as I find that the most dangerous issue. Thanks for testing!

JamesMessinger commented 9 years ago

agreed, that seems like the top priority