Closed JamesMessinger closed 9 years ago
Just committed some more fixes.
idxRow
)clearQueue()
was sometimes being called on the wrong objectThanks! Will look at this tomorrow :) Nice fixes btw :)!
With these fixes in place, almost all of the IndexedDBShim unit tests pass on Windows Phone 8.1. Only 19 tests (out of 314) are still failing. All of the failing tests are caused by these three bugs:
IDBObjectStore.add()
is behaving like IDBObjectStore.put()
.catch
block in Database.js was suppressing errors entirely. I fixed that by adding a call to onError()
. Now errors are being thrown appropriately, but they're being caught by Cordova, which then fires a cordovacallbackerror
event. That's better than nothing, since this event can be listened for, but it's supposed to fire a window.onerror
event instead.@BigstickCarpet, merged by @Nimrodxx and thanks for the PR.
Need to look into the Duplicate primary keys in simultaneous transactions
as I find that the most dangerous issue. Thanks for testing!
agreed, that seems like the top priority
Hi @DickvdBrink and @Nimrodxx. Thanks again for open-sourcing this plug-in. I've created a new IndexedDB plugin that uses this plugin instead of the MSOpenTech one. I also made a few changes to this plugin to simplify the installation process. Here are the changes I made:
after_plugin_install
hook that takes care of modifying the.jsproj
and.sln
files, so now there aren't any manual post-installation stepspackage.json
file and renamed the plugin according to the new naming convention (cordova-plugin-websql-async
). You can publish the plugin to npm using thenpm publish
command. Let me know once you've done that, and I'll update the IndexedDB plugin to point to your npm package.