Should expose on window instead of WebSQL

Thinkwise / cordova-plugin-websql

Cordova WebSQL plugin for Windows Phone

4 stars 9 forks source link

Should expose on window instead of WebSQL #10

Closed joeljeske closed 9 years ago

joeljeske commented 9 years ago

Currently, this plugin exposes itself as window.WebSQL.openDatabase. To be consistent as a websql plugin, it should also/instead expose as window.openDatabase.

This could be fixed by changing this line in config.xml to read

<merges target="window" />

instead of

<clobbers target="window.WebSQL" />

This is also consistent with the forked project.

JamesMessinger commented 9 years ago

Once this change is made, I'll update this line in the cordova-plugin-indexeddb-async plug-in.

masonicboom commented 9 years ago

Agreed. @joeljeske: submit a PR?