search

Thinstation / thinstation

A framework for making thin and light Linux based images for x86 based machines and thinclients.
https://www.thinstation.net/
788 stars 188 forks source link

local-install upgrade from systemd service file #702

Open gtny opened 2 years ago

gtny commented 2 years ago

I'm using local-install and while looking to get hdupdate to work, I noticed in /var/log/messages that "local-install.sh upgrade" is running at boot, but failing because it runs before dhcp has received an IP.

Looking at the systemd service file, it looks like it's intentionally being run before the network. I'm not sure how it would ever work in this way.

It begs another question, is hdupdate the recommended way to update an installed thinstation, or is local-install the way to go after some tweaks?

Here is the service file in question with the Before statement that I'm wondering about: /ts/build/packages/local-install/etc/systemd/system/local-install.service

[Unit]
Description=ThinStation Local Install
After=profile-setup.service
Before=network-pre.target
ConditionPathIsReadWrite=/etc

[Service]
Type=oneshot
RemainAfterExit=yes
EnvironmentFile=/etc/thinstation.env
ExecStart=/etc/init.d/local-install
SyslogIdentifier=thinstation

[Install]
WantedBy=multi-user.target
Thinstation commented 2 years ago

local-install may expect to install from removable media. That would not be the case when booting from the network, so some adjusting may be necessary. I can't test everything.