TTS - Fix crash on second pass, fix azure SSML when using pause - Githubissues

ThioJoe / Auto-Synced-Translated-Dubs

Automatically translates the text of a video based on a subtitle file, and also uses AI voice to dub the video, and synced using the subtitle's timings

GNU General Public License v3.0

1.55k stars 152 forks source link

TTS - Fix crash on second pass, fix azure SSML when using pause #17

Closed sofiadparamo closed 1 year ago

sofiadparamo commented 1 year ago

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Proposed Changes

Move the pauseTag to inside the voice body instead of as a property
Move keyIndex assignment outside of condition for loop to work when synthesizing on the second pass

Additional Info

Fixes #15
Fixes #16

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested that the code works

Required:

By contributing to this project, you agree to the terms of the GPLv3 license, and agree to grant the project owner the right to also provide or sell this software, including your contribution, to anyone under any other license, with no compensation to you.
[X] I agree

ThioJoe commented 1 year ago

Ah good catch, I use the batch mode so I never saw that issue