ThioJoe / Auto-Synced-Translated-Dubs

Automatically translates the text of a video based on a subtitle file, and also uses AI voice to dub the video, and synced using the subtitle's timings
GNU General Public License v3.0
1.55k stars 152 forks source link

Refactor/audio builder #2

Closed myLogic207 closed 1 year ago

myLogic207 commented 1 year ago

PLEASE ONLY SUBMIT PULL REQUESTS FOR BUG FIXES OR LEGITIMATELY USEFUL ADDITIONAL FUNCTIONALITY

I know many of you are enthusiastic to help but I don't want this project to become bloated


Type of change

Proposed Changes

There are many changes but it boils down to just renaming, refactoring and other small improvements. Also I changes the main for loops to just one which hopefully improves speed. (It might cost additional ram, so I am ready to revert this change ^^')

Also I added a little bit of documentation

Additional Info

I did not test the code as I have no video or anything else ready, if required I can do it in the future.

Checklist:

Required:

myLogic207 commented 1 year ago

Hey, I just saw your video over on youTube and really liked the idea! While looking at your code I had some hopefully useful improvements in mind and thought it might be a good time to spend a little bit more time with python ;) No problems if you close it because you don't like it ^^