search

ThioJoe / YT-Spammer-Purge

Allows you easily scan for and delete scam comments using several methods.
GNU General Public License v3.0
4.57k stars 389 forks source link

Package issue on certain Linux distributions #1131

Closed YuvanMichaelVivenzi closed 1 month ago

YuvanMichaelVivenzi commented 2 months ago

On installation for Linux, I think one small issue should be addressed. Instead of just using python's pip command and expecting it to work, I believe a separate command should also be included. Which uses the distribution's package manager. On supported distributions like Arch and Debian. I believe in certain customized ones like (Garuda Linux based on Arch). Which make "pip install "xyz"" be managed externally through pacman, as "pacman -S python-"xyz"" should be put in the wiki as a small note.

It could be useful for some new linux users to get some help on the wiki in certain environments like these. As most new users just use a "easy, hassle-free, distro" for their everyday use. And certain distributions have certain policies configured such as managing python packages externally through the package manager rather than pip.

The install script can be changed to use the distribution's package manager in case, using pip fails. As pip doesn't allow packages to be installed when python packages are managed externally by the distribution's package manager. And passing dangerous flags like "--break-system-packages" is not something anyone would want to do.

Screenshots

20240709_17h14m01s_grim

P.S. Great work you're doing on this project. And happy to keep contributing like I've done before. #700 #739

YuvanMichaelVivenzi commented 2 months ago

EDIT: Found out that even Arch Linux does this by default.

YuvanMichaelVivenzi commented 2 months ago

The script should be modified to reflect the changes made in arch. It should be simple enough to make pip install 'xyz' to sudo pacman -S python-'xyz' and some are available in the aur. so, doing a yay -S 'xyz' would do the job for all requirements.

YuvanMichaelVivenzi commented 2 months ago

I don't know enough to fix it in the script. But maybe by brainstorming for a while, I might be able to get it to work.

YuvanMichaelVivenzi commented 1 month ago

um, hello?

YuvanMichaelVivenzi commented 1 month ago

Closing the issue as it's not that important and can be fixed with manual installation. This issue was intended to just be an update (reminder) to the maintainers and authors to update the script. As in it's current state it is most likely to fail on most systems even on default settings.