ThioJoe / YT-Spammer-Purge

Allows you easily scan for and delete scam comments using several methods.
GNU General Public License v3.0
4.57k stars 389 forks source link

Grammar Mistakes And Added Colors In Some Places #925

Closed Rohith0009 closed 6 months ago

Rohith0009 commented 2 years ago

Related Issue/Addition to code

Type of change

Features And a Very Minor Fix

Proposed Changes

Why is this change needed?

It's required because YT Spammer Purge Needs good grammar and spelling. The Second Change Is Needed So That The Terminal Looks Good And Colorful. The Fixes are So that the code runs properly. ### Additional Info - Changed Colors in Headings And Inputs - In Scripts/auth.py line number 154. Both Prints were on the same line ### Checklist: - [x] My code follows the style guidelines of this project and I have read [CONTRIBUTING.md](/CONTRIBUTING.md) - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published in downstream modules - [x] I have checked my code and corrected any misspellings --- ### Screenshots ### Original ![Before](https://user-images.githubusercontent.com/87482502/192131788-d8fb383b-6710-4aa9-9aeb-06d90276e36b.png) ### Updated ![After](https://user-images.githubusercontent.com/87482502/192131793-9143ccae-39da-4f0e-bc90-93002ac9aea9.png)
Rohith0009 commented 2 years ago

Also I Removed The "Big Bruh Moment" As I don't think those types of words belong here. If you don't like this change I can revert it.

Rohith0009 commented 2 years ago

I’m no grammar or spelling expert, but I’m reasonably sure the change to line 616 of prepare_modes.py is incorrect. The original infers multiple “commenters”. As “commenter” is singular, the proposed change would turn the singular into singular possessive, which I’m fairly sure isn’t the required meaning.

So Should I change it back?

ThioJoe commented 2 years ago

I’m no grammar or spelling expert, but I’m reasonably sure the change to line 616 of prepare_modes.py is incorrect. The original infers multiple “commenters”. As “commenter” is singular, the proposed change would turn the singular into singular possessive, which I’m fairly sure isn’t the required meaning.

So Should I change it back?

Yea there shouldn't be an apostrophe there

Rohith0009 commented 2 years ago

I’m no grammar or spelling expert, but I’m reasonably sure the change to line 616 of prepare_modes.py is incorrect. The original infers multiple “commenters”. As “commenter” is singular, the proposed change would turn the singular into singular possessive, which I’m fairly sure isn’t the required meaning.

So Should I change it back?

Yea there shouldn't be an apostrophe there

Ok I have changed it. Is Everything else Ok?

Rohith0009 commented 2 years ago

@ThioJoe I added a new bug fix is it ok?

ThioJoe commented 2 years ago

@ThioJoe I added a new bug fix is it ok?

What's the bug exactly? Your code actually breaks some things, for example if there's an invalid input it just keeps the program going anyway. Probably better to revert 5a2bf9c

Rohith0009 commented 2 years ago

What's the bug exactly? Your code actually breaks some things, for example if there's an invalid input it just keeps the program going anyway. Probably better to revert 5a2bf9c

Done. Sorry for breaking the code

Rohith0009 commented 2 years ago

README.md line 88, fairly irrelevant but I don’t believe Simply and Click should be compounded.

I don't think for makes a good sentence over there.

spankywetfish commented 1 year ago

I hope not

Rohith0009 commented 1 year ago

Is that one error going to stay that way?

Going to fix it

LoftyDroid commented 1 year ago

hey, can you assign this to me? I would like to contribute to this repo.

LunaticBFF57 commented 1 year ago

hey, can you assign this to me? I would like to contribute to this repo.

I don't think that the pull request can be assigned to you Lofty, FYI.

dwarfpuzzles commented 1 year ago

Sure.

virophagesp commented 6 months ago

hey is this still being worked on

LunaticBFF57 commented 6 months ago

Yo @Rohith0009?

LunaticBFF57 commented 6 months ago

Wait, are you not working on this or for some other reason?