ThioJoe / YT-Spammer-Purge

Allows you easily scan for and delete scam comments using several methods.
GNU General Public License v3.0
4.52k stars 391 forks source link

Improve README.md accessibility for screen readers #995

Closed throwaway-d closed 6 months ago

throwaway-d commented 1 year ago
  1. The "issue" and "pull request" badges are removed because they're obvious that you can already see the counters on GitHub.
  2. Add height = '20' for the remaining badges. https://web.dev/optimize-cls/#images-without-dimensions
  3. Improve alt texts of the badges (the alt texts on ## Screenshots is still not worked on yet)
  4. Add height = '353' for the screenshots https://web.dev/optimize-cls/#images-without-dimensions
  5. Remove some unnecessary trailing slashes on img elements README.md https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements

Related Issue

Type of change

Checklist:


Screenshots

Original Updated
image image
throwaway-d commented 1 year ago

I'm very newbie to GitHub and PRs. Please kindly guide me if anything's wrong. I mostly stay on Codeberg and create issues. (https://github.com/ThioJoe/YT-Spammer-Purge/discussions/994)

throwaway-d commented 1 year ago

I will try to convince him since this impacts accessibility of blind people.

KendallDoesCoding commented 1 year ago

I will try to convince him since this impacts accessibility of blind people.

ok šŸ¤·

throwaway-d commented 1 year ago

for now

Even he didn't really confirm that he would keep it forever. He was just procrastinating at that time.

throwaway-d commented 1 year ago

A good guide about alt text: https://www.w3.org/WAI/tutorials/images

throwaway-d commented 11 months ago

@ThioJoe It has been many months already. Can you please merge my PR?