search

Thiousi / kirby-color-list

A color picker in the form of a list of colors for Kirby
MIT License
25 stars 4 forks source link

Don't use <?= #2

Closed jenstornell closed 8 years ago

jenstornell commented 8 years ago

Many people dont have <?= enabled. Instead use <?php echo.

Thiousi commented 8 years ago

I thought the issue was with <? instead of <?php From PHP 5.4 at least. Is this a problem you think ?

jenstornell commented 8 years ago

I would not take the risk as I know it's like asking for trouble. Look how the Starterkit does it.

https://github.com/getkirby/starterkit/blob/master/site/snippets/projects.php

Thiousi commented 8 years ago

Probably wise! I like the shorthand better but will avoid it ;)

jenstornell commented 8 years ago

I would say, use the shorthand when you build stuff for yourself, don't when you build stuff for others. :)

Thiousi commented 8 years ago

Fixed! Thanks