Third-Culture-Software / bhima

A hospital information management application for rural Congolese hospitals
https://docs.bhi.ma/
GNU General Public License v2.0
220 stars 105 forks source link

(feature request) show default filters on registry PDFs #1909

Closed jniles closed 7 years ago

jniles commented 7 years ago

Some of our registry PDFs include the search filters sent back to the server on them. However, these are limited to only the custom filters and do not include default filters. Default filters (particularly the LIMIT) provide important contextual information. We should include them on the printed PDF registries. See below:

patientregistrationnodefaultfilters Fig 1: Patient Registrations without any custom filters

jniles commented 7 years ago

@jeremielodi, can you look into this?

The basic idea is to put the filters that we see on the client like this:

defaultfilters Fig 1: Default Filters

.. on the server PDF reports.

To render on the PDF report. A good example of how filters can be rendered on the server is seen in the Patient Registrations Report.

It should be pretty straight-forward. Let me know if you need any help!

jeremielodi commented 7 years ago

Yes, I can look into it but my internet connection is very slow now

Le 9 août 2017 10:58, "Jonathan Niles" notifications@github.com a écrit :

@jeremielodi https://github.com/jeremielodi, can you look into this?

The basic idea is to put the filters that we see on the client like this: [image: defaultfilters] https://user-images.githubusercontent.com/896472/29116032-7b79be18-7cf1-11e7-944e-cded8fd9af93.png Fig 1: Default Filters

To render on the PDF report. A good example of how filters can be rendered on the server is seen in the Patient Registrations Report https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/server/controllers/medical/reports/registrations.handlebars#L9 .

It should be pretty straight-forward. Let me know if you need any help!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IMA-WorldHealth/bhima-2.X/issues/1909#issuecomment-321210887, or mute the thread https://github.com/notifications/unsubscribe-auth/AYpCKTQM747fwmS7k2VGPxOymc1H6iqoks5sWYLegaJpZM4OofZ- .

jniles commented 7 years ago

Closed in #1947.