search

Third-Culture-Software / bhima

A hospital information management application for rural Congolese hospitals
https://docs.bhi.ma/
GNU General Public License v2.0
218 stars 104 forks source link

chore(deps): bump puppeteer from 22.15.0 to 23.3.1 #7717

Closed dependabot[bot] closed 1 month ago

dependabot[bot] commented 1 month ago

Bumps puppeteer from 22.15.0 to 23.3.1.

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v23.3.1

23.3.1 (2024-09-16)

Bug Fixes

  • improve Precision of Paper Sizes in Inches to 4 Decimal Places (#13087) (47d6c44)
  • roll to Chrome 128.0.6613.137 (#13071) (27df147)

puppeteer: v23.3.1

23.3.1 (2024-09-16)

Miscellaneous Chores

  • puppeteer: Synchronize puppeteer versions

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 23.3.0 to 23.3.1

puppeteer-core: v23.3.0

23.3.0 (2024-09-04)

Features

Bug Fixes

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @​puppeteer/browsers bumped from 2.3.1 to 2.4.0

puppeteer: v23.3.0

23.3.0 (2024-09-04)

Miscellaneous Chores

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 1 month ago

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

jmcameron commented 1 month ago

Did some investigation into why this version of Puppeteer does not work. It looks like something has changed in the PDF renderer (may be related to changes in puppeteer that need changes to coral). With the old puppeteer, the pdf.render returns a Uint8Array object, that prints out like this (in test/server-unit/pdf.spec.js): {8CACEEBD-537E-47C9-832F-4292DF7314BE}

With the new version, the contents of the Uint8Array are different, and test/server-unit/pdf.spec.js fails: {F0884AE8-F7C0-4137-948F-52BA3C4B5070}

Note that it is no longer a Buffer. Extracting the PDF tag from the data files because it no longer behaves like a string. Perhaps puppeteer is handling UTF8 data differently. I did not see anything about it in the release notes.

I tried modifying the server/lib/renderers/pdf.js render() function to convert it to a string. But that failed because the test checks to see if it is a Buffer (even though the test for the PDF tag works). Converting the results to a string may limit the length of the file that can be handled. I presume that keeping it as a Buffer avoids that limitation.

dependabot[bot] commented 1 month ago

Superseded by #7721.