Bootstrap mixin most likely doesn't/shouldn't need to wrap display mixin

ThirdCornerLLC / tc-grid

A declarative grid for AngularJS

MIT License

14 stars 2 forks source link

Bootstrap mixin most likely doesn't/shouldn't need to wrap display mixin #10

Closed timgit closed 9 years ago

timgit commented 9 years ago

Bootstrap should only be a style mixin

Zacharias3690 commented 9 years ago

do we want to remove the requirement for tcDisplay in custom classes? It gives us some power when it comes to mobile designs, and technically the display is part of the class.

timgit commented 9 years ago

My original idea was that display should be common across all custom styles and implemented globally. Just opened the less again and I see a media query that's not wrapped in the mixin, so it's kind of in a weird state. We could leave it as a mixin if we want, but it would work equally well if we just inlined all the code directly in the .tcGrid__scope block.