search

ThirdCornerLLC / tc-grid

A declarative grid for AngularJS
MIT License
14 stars 2 forks source link

loading indicator #19

Open johntseng opened 9 years ago

johntseng commented 9 years ago

Can we show something to indicate that the grid is loading?

Zacharias3690 commented 9 years ago

I think we could do this with some sort of callback passed in to onPage/SortChange similar to what gulp does to end tasks.

timgit commented 9 years ago

Agreed. We could just add an optional callback to these methods and a config setting to turn on a loading animation. The visualization could be a configurable class that's added/removed so it can be customized. So now the only question is which animated gif are we going to ship for this? :)

Zach-Barnes-Volusion commented 9 years ago

Where's a good position to place the visual? Anywhere on the table will look awkward, and outside of the table is outside the scope of tc-grid

goofygrin commented 9 years ago

the whole grid going to a spinner?

On Wed, May 13, 2015 at 9:25 AM, Zach-Barnes-Volusion < notifications@github.com> wrote:

Where's a good position to place the visual? Anywhere on the table will look awkward, and outside of the table is outside the scope of tc-grid

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-101685094 .

Zacharias3690 commented 9 years ago

What about graying out the grid and overlaying a loading indicator in the middle of it?

goofygrin commented 9 years ago

That's what I was suggesting. On May 14, 2015 8:48 AM, "Zach Barnes" notifications@github.com wrote:

What about graying out the grid and overlaying a loading indicator in the middle of it?

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102042834 .

Zacharias3690 commented 9 years ago

Oh okay, I thought you mean replacing the grid with a loading indicator.

On Thu, May 14, 2015 at 8:53 AM Sean Goodpasture notifications@github.com wrote:

That's what I was suggesting. On May 14, 2015 8:48 AM, "Zach Barnes" notifications@github.com wrote:

What about graying out the grid and overlaying a loading indicator in the middle of it?

— Reply to this email directly or view it on GitHub < https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102042834

.

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102043908 .

goofygrin commented 9 years ago

That's an implementation detail ;) On May 14, 2015 8:54 AM, "Zach Barnes" notifications@github.com wrote:

Oh okay, I thought you mean replacing the grid with a loading indicator.

On Thu, May 14, 2015 at 8:53 AM Sean Goodpasture <notifications@github.com

wrote:

That's what I was suggesting. On May 14, 2015 8:48 AM, "Zach Barnes" notifications@github.com wrote:

What about graying out the grid and overlaying a loading indicator in the middle of it?

— Reply to this email directly or view it on GitHub <

https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102042834

.

— Reply to this email directly or view it on GitHub < https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102043908

.

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102044043 .

timgit commented 9 years ago

My 2 cents opinion on this would be a pure CSS approach if possible. If the hosting app has a standard for their loading indicators, and if it were CSS as well, they could just give us their class to override our default class.

goofygrin commented 9 years ago

agreed.

On Thu, May 14, 2015 at 9:31 AM, Tim Jones notifications@github.com wrote:

My 2 cents opinion on this would be a pure CSS approach if possible. If the hosting app has a standard for their loading indicators, and if it were CSS as well, they could just give us their class to override our default class.

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102053122 .

Zacharias3690 commented 9 years ago

Agreed. However, I'm not sure how we can do a pure unicode loading indicator.

On Thu, May 14, 2015 at 9:31 AM Tim Jones notifications@github.com wrote:

My 2 cents opinion on this would be a pure CSS approach if possible. If the hosting app has a standard for their loading indicators, and if it were CSS as well, they could just give us their class to override our default class.

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102053122 .

goofygrin commented 9 years ago

You can have it be a background image...

On Thu, May 14, 2015 at 9:35 AM, Zach Barnes notifications@github.com wrote:

Agreed. However, I'm not sure how we can do a pure unicode loading indicator.

On Thu, May 14, 2015 at 9:31 AM Tim Jones notifications@github.com wrote:

My 2 cents opinion on this would be a pure CSS approach if possible. If the hosting app has a standard for their loading indicators, and if it were CSS as well, they could just give us their class to override our default class.

— Reply to this email directly or view it on GitHub < https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102053122

.

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102054010 .

Zacharias3690 commented 9 years ago

Yes, but that's not a pure CSS implementation ;)

goofygrin commented 9 years ago

Sure it is... it's just a class that someone puts together... We're not expecting an image.

On Thu, May 14, 2015 at 9:37 AM, Zach Barnes notifications@github.com wrote:

Yes, but that's not a pure CSS implementation ;)

— Reply to this email directly or view it on GitHub https://github.com/ThirdCornerLLC/tc-grid/issues/19#issuecomment-102054982 .

timgit commented 9 years ago

data URIs ftw