search

ThirteenAG / GTAIV.EFLC.FusionFix

This project aims to fix or address some issues in Grand Theft Auto IV: The Complete Edition
GNU General Public License v3.0
974 stars 44 forks source link

[Issue] Cutscenes still stutter after FusionFix 2.0 #246

Open RecklessGlue540 opened 1 year ago

RecklessGlue540 commented 1 year ago

Cutscene stuttering is still present after FF 2.0. Cutscene zooming was indeed fixed, but jitter is still there. How it should look: https://www.youtube.com/watch?v=yltP_dYU3mE

Undisputed00x commented 1 year ago

Just for the record removing cutscenes.rpf from GTA IV\pc\audio\sfx fixes the issue but removes the sounds from game cutscenes

TailsGuy commented 10 months ago

I've been messing around with cutscene FPS cap limits and not even 30FPS solves anything here.

RecklessGlue540 commented 10 months ago

I've been messing around with cutscene FPS cap limits and not even 30FPS solves anything here.

I know. This stutter is present at any framerate.

RecklessGlue540 commented 10 months ago

The issue has been tackled with latest the update. Stutter is still there however. Nowhere near a full fix. I can confirm it's a bit smoother.

JackSound01 commented 10 months ago

The issue has been tackled with latest the update. Stutter is still there however. Nowhere near a full fix. I can confirm it's a bit smoother.

Still stutters like the old version..

RecklessGlue540 commented 10 months ago

In some ways... Maybe because I also upgraded my GPU... (probably Enhanced Sync and other things influence it...)

hammerfist11 commented 10 months ago

Is there any identified reason it does this? It's quite annoying given how story focused the game is.

RecklessGlue540 commented 10 months ago

Is there any identified reason it does this? It's quite annoying given how story focused the game is.

Actually not yet. There's countless theories about it in the previous thread tho https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/issues/58

ThirteenAG commented 10 months ago

GTAIV.EFLC.FusionFix.zip

Can someone test this build for this issue?

TailsGuy commented 10 months ago

GTAIV.EFLC.FusionFix.zip

Can someone test this build for this issue?

I can, give me a moment.

TailsGuy commented 10 months ago

Actively better, this time round it doesn't seem as if the animations are stuttering, rather they're running at a different FPS.

ThirteenAG commented 10 months ago

Is it something good enough to include in the next release?

TailsGuy commented 10 months ago

Is it something good enough to include in the next release?

Hm. Honestly, yeah, go for it. It's a notable improvement. It ain't completely fixed but it's satisfactory for now. Needs more research for sure though

Undisputed00x commented 10 months ago

Its not fixed, just moved cutscenes.rpf away from its folder and compare, its nowhere near to that. Please dont prematurely close this ticket like the #58

ThirteenAG commented 10 months ago

Removing cutscenes.rpf doesn't make any difference to me.

TailsGuy commented 10 months ago

Damn, I must have been mistaken, sorry. It's still in fact stuttery but I figured it wasn't as intense. Maybe it varies on a case by case?

TailsGuy commented 10 months ago

Removing cutscenes.rpf doesn't make any difference to me.

Damn, I must have been mistaken, sorry. It's still in fact stuttery but I figured it wasn't as intense. Maybe it varies on a case by case?

ThirteenAG commented 10 months ago

I have no clue ¯_(ツ)_/¯

Tomasak commented 10 months ago

with and without said rpf feels absolutely same https://streamable.com/urj6hs https://streamable.com/4c3cum (using asi from this issue)

Undisputed00x commented 10 months ago

with and without said rpf feels absolutely same https://streamable.com/urj6hs https://streamable.com/4c3cum (using asi from this issue)

Even from your recordings the microstuttering is visible

RecklessGlue540 commented 10 months ago

Nope. Still not fixed. The animations do seem smoother a bit... but now, they look like they play flat out at a 30hz smoothness instead of constantly fluctuating... They still stutter. Will have to try without cutscenes.rpf

Tomasak commented 10 months ago

with and without said rpf feels absolutely same https://streamable.com/urj6hs https://streamable.com/4c3cum (using asi from this issue)

Even from your recordings the microstuttering is visible

im not arguing that, im only pointing out that removing cutscenes.rpf does nothing

RecklessGlue540 commented 10 months ago

with and without said rpf feels absolutely same https://streamable.com/urj6hs https://streamable.com/4c3cum (using asi from this issue)

Even from your recordings the microstuttering is visible

im not arguing that, im only pointing out that removing cutscenes.rpf does nothing

It does for me: (even with this asi) https://streamable.com/n1cl70 Set your screen to 60hz for the best result

And this is with the fix above: https://streamable.com/q321zb

RecklessGlue540 commented 10 months ago

with and without said rpf feels absolutely same https://streamable.com/urj6hs https://streamable.com/4c3cum (using asi from this issue)

For the second one, it looks smooth but it looks like 30fps... you might have recorded it at that fps The first one does have stutters tho... I can clearly see it.

ThirteenAG commented 10 months ago

https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/assets/4904157/ccd523a7-fa86-4c9d-ba4d-b05c333aeb5a

That's what I see without fixes, and this is what I don't see with asi above.

https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/assets/4904157/4a95be81-aa2b-4688-9c0f-d68cf8a0ddc1

RecklessGlue540 commented 10 months ago

Grand.Theft.Auto.4.2024.01.15.-.21.44.07.06.mp4 That's what I see without fixes, and this is what I don't see with asi above.

Grand.Theft.Auto.4.2024.01.15.-.21.50.21.07.mp4

That trembling? I'm pretty much talking about the overall cutscene smoothness, tho I've seen that tremble in the intro when the car (schafter) is being lifted, even with this .asi... that's a good section to test on.

Again, this is how smooth cutscenes should look: https://www.youtube.com/watch?v=yltP_dYU3mE And again, watch it at 60hz.

ThirteenAG commented 10 months ago

GTAIV.EFLC.FusionFix.zip

Try with this.

RecklessGlue540 commented 10 months ago

GTAIV.EFLC.FusionFix.zip

Try with this.

No difference. Car still trembles. https://streamable.com/lz865v

ThirteenAG commented 10 months ago

https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/assets/4904157/1782e028-b92c-435a-ac9b-3c033dbf3648

Not as much for me. But I did restore previous version of cutscene fix for this test, dunno if related.

GTAIV.EFLC.FusionFix.zip

RecklessGlue540 commented 10 months ago

Still no difference...

TailsGuy commented 10 months ago

I'll try this when I'm home.

TessellatedGuy commented 9 months ago

The animation stuttering is a lot less visible at higher framerates for me, so if you play at 60 fps, it would feel a lot worse than if you were constantly holding 120 fps+ during cutscenes (even beyond just the difference between 60 and 120 fps). Capping the game at 60 fps vs 120 fps using FusionFix's framerate limiter shows a massive difference in cutscene smoothness (sorry for the crudely edited video):

https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/assets/13260031/bc5361ec-58c3-465f-b46b-a7eda38986d6

Slowed down to half speed (0.5x):

https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/assets/13260031/274b5207-d0d0-4dc8-9ea3-3d082045e433

Both the 60 fps and 120 fps versions were recorded at 60 fps, which means under normal circumstances (most other games) the 120 fps clip on the right wouldn't have an advantage in smoothness, since only half (60) of the frames rendered by the GPU were recorded. I also used the newest FusionFix .asi from this page for these videos.

To me, 120 fps looks more like "real" 60 fps here, despite both videos being recorded and exported at 60 fps.

I'd assume a locked 240 fps would look even smoother, but unfortunately my PC gets CPU bottlenecked so it never gets 240 fps in the scene I used for testing, even at the lowest settings. On the other end of the spectrum, a 30 fps lock makes the stuttering even worse.

Somehow, having a very high framerate reduces the animation stutter significantly, and I'm not really sure why. I hope this can help fix this issue or narrow down the cause. If this was already common knowledge, please ignore this comment.

RecklessGlue540 commented 9 months ago

The animation stuttering is a lot less visible at higher framerates for me, so if you play at 60 fps, it would feel a lot worse than if you were constantly holding 120 fps+ during cutscenes (even beyond just the difference between 60 and 120 fps). Capping the game at 60 fps vs 120 fps using FusionFix's framerate limiter shows a massive difference in cutscene smoothness

This is what I think as well. I think all of these fixes are meant to be used at absurd framerates, which is not preferable, since it's well known the game breaks above even 60.

All the footage ThirteenAG has shown runs at abysmally high framerates. That's probably why he doesn't notice differences with or without cutscenes.rpf sound files... So I guess this is more of an issue at lower framerates like 60 or 30 (just like loading times)...

And, from what I've seen, when you run the cutscenes at 30fps, their smoothness seems to be 20fps-ish... When running at 60, they seem to be 30fps-ish or so...

TessellatedGuy commented 9 months ago

And, from what I've seen, when you run the cutscenes at 30fps, their smoothness seems to be 20fps-ish... When running at 60, they seem to be 30fps-ish or so..

I noticed this as well, and that might explain why 120 fps looks more like "60 fps" in my video, but not quite "perfect" 60 fps. If this hypothesis is true, at 240 fps you'd be getting roughly ~120 fps smoothness but with some stutter. I would guess that since 120 fps is just naturally a very high framerate, you notice less of those stutters, which only happen for a few frames out of 120 frames every second. At 120 fps (with ~60 fps cutscene animations), those "few frames" of stutter would take up a lot more time on screen per second.

This also might mean the stutter happens for a fixed amount of frames, so no matter your framerate, you're only going to stutter/drop 3 frames in a second of an animation (for example). At 30 fps, 3 frames is a lot, but at 120 fps, 3 frames is a drop in the bucket.

Of course, I might be wrong about this, since I can't actually prove it.

Undisputed00x commented 9 months ago

@TessellatedGuy @RecklessGlue540

no, still my cutscenes play around 170- 230 fps and comparing to w/o cutscenes.rpf trick the difference is still big, cutscenes again feel playing in like close to 60fps framerate. Only w/o cutscenes.rpf there is true visible fluidity in the game's cutscenes on my 144hz display.

TessellatedGuy commented 9 months ago

no, still my cutscenes play around 170- 230 fps and comparing to w/o cutscenes.rpf trick the difference is still big, cutscenes again feel playing in like close to 60fps framerate. Only w/o cutscenes.rpf there is true visible fluidity in the game's cutscenes on my 144hz display.

I agree, there is definitely still visible stutter at higher framerates. I was more talking about how much worse the stuttering is at lower framerates and why that may be.

Also, I recorded a clip of that scene with cutscenes.rpf removed, with the same .asi and 60 fps limit as before, and the difference is remarkable:

https://github.com/ThirteenAG/GTAIV.EFLC.FusionFix/assets/13260031/251b2feb-8f0d-441f-9f88-4c3423159580

That finally looks like a flawless 60 fps as you'd expect, and smoother than when I tried running that cutscene normally at 165 fps, which is my monitor's max refresh rate.

ThirteenAG commented 9 months ago

I doubt anything can be done about that until someone finds a code path to disable, that will make cutscenes act like without rpf. I personally barely see a difference (with high fps), and what I've looked for is how to avoid jitter, since I can reproduce it immediately. If it doesn't break anything, I'll include it in the next release. The rest is separate issue.

hammerfist11 commented 9 months ago

All I can say is that for me when playing at a capped 60fps, the cutscenes are noticeable laggy, and it takes away from the experience quite a bit given how story driven the game is. Glad you're working on it, but disappointed that there is still no identified reason that's causing this given how long it's been an issue.

RecklessGlue540 commented 9 months ago

@Undisputed00x, @TessellatedGuy, @JackSound01, @TailsGuy Can y'all test FusionFix 2.4.9? For some reason the stutters for me are quite reduced... (seems to be quite close to Xbox 360 smoothness at 60fps now). Y'all could try capping the fps to both 60 and 120, and see if there's any differences.

Undisputed00x commented 9 months ago

@RecklessGlue540 no difference from me. By capping the game makes it even worse

RecklessGlue540 commented 9 months ago

The rest is separate issue.

Ahh, I understand now. So the jittering, zooming and stuttering are all separate issues... I see... interesting for sure.

until someone finds a code path to disable, that will make cutscenes act like without rpf...

Would things really be that easy tho? I doubt it...

Anyway, On a side note, a lot of Rockstar's RAGE games seem to have this "stuttering" issue in cutscenes... Notable examples include RDR1 and GTAV... Max Payne 3 seems to be free from this, thankfully...

HAYASHIDASEIYAKU commented 9 months ago

I remember this problem also exists in GTASA. The police car in the opening animation has a similar shaking problem. But SilentPatch seems to have fixed this problem. Maybe ask him?

RecklessGlue540 commented 8 months ago

@Undisputed00x, @JackSound01, @TessellatedGuy Can you guys try out capping the cutscenes through FF at 32fps, 64fps, 128fps and 256fps and see how the smoothness is? Of course with all of these fixes enabled.

On patch 1.0.0.0, cutscenes were hard capped at 32. And keep in mind, the cutscene audio files are 32000hz, so that means 32000hz cutscene audio = 32fps for proper sync?

I found 128fps to be the smoothest...

Undisputed00x commented 8 months ago

@RecklessGlue540 We've done that in the past and like expected still issue hasn't been resolved either by capping the frames or not. I dunno but there are moments depending the scene when framerate is fluid as it should, also i notice this in the last frames when skipping the cutscenes.

RecklessGlue540 commented 8 months ago

@RecklessGlue540 We've done that in the past and like expected still issue isnt resolved either by capping the frames or not. I dunno but there are moments depending the scene when framerate is fluid as it should, also i notice this in the last frames when skipping the cutscenes.

Yeah, when cutscenes change sections and during the screen fade ins / outs, they are completely smooth.

HAYASHIDASEIYAKU commented 8 months ago

The fade-in effect will cause the game to skip frames. The best place to test this is in the theater. After watching a show with friends, there is a high probability that their first words will be sped up. You can only know this by watching the conversation history.

Joris-truly commented 3 months ago

Adding to the issue of 'camera judder in cutscenes still being a problem at 60fps': I tried deleting the cutscenes.rpf to see it for myself, and it's staggering how smooth the cutscenes suddenly are. What a mess of spaghetti code this engine must be to create such a problem.

Undisputed00x commented 3 months ago

This problem hasn't been fixed (although didn't intended to be) in the new 3.0v update.

hammerfist11 commented 3 months ago

This problem hasn't been fixed (although didn't intended to be) in the new 3.0v update.

sad face

JackSound01 commented 2 months ago

Playing at 120fps and above seems to be very smooth but at 60fps stutters a lot, any fix??