ThirteenAG / III.VC.SA.IV.Project2DFX

Project2DFX is a set of plugins for GTA III, Vice City, San Andreas, GTA IV: The Complete Edition, GTA Liberty City Stories and GTA Vice City Stories, which adds LOD corona effect to a game map, making LOD-world look a lot better.
https://thirteenag.github.io/p2dfx
MIT License
252 stars 22 forks source link

[VC] P2DFX crashes the game #51

Closed MotorBoatMan closed 12 months ago

MotorBoatMan commented 12 months ago

For some reason after adding the P2DFX plugin the game started crashing giving me an error and after I removed it the game ran just fine.

The error: GTA VC Error

The log: gta-vc.exe.20231128004449.log (the dump is too big to upload)

Game version: v1.0 (No-CD by gimpRus) Installed plugins: Widescreen Fix + Widescreen Frontend, SilentPatch + SilentPatchDDraw, GInput, SkyGfx, Portable GTA and lastly P2DFX (which causes the crashes)

PC Specs: CPU: Intel Core i5-8400 GPU: Nvidia GeForce GTX 1080 RAM: 16 GB 3200 MT/s OS: Windows 10 Pro 22H2

Let me know if you need to know more or if it's something on my end that's causing the crashes.

ThirteenAG commented 12 months ago

No idea, it crashes in CStreaming::RemoveLoadedVehicle().

MotorBoatMan commented 12 months ago

Is there a way I can help/provide you more helpful info or anything? If there's a way I can help I'll gladly do so, since I have no idea what is causing this issue (I don't even know what the error means as I have no vehicle mods, no mod menus/ZMenu, no CLEO or anything). Just to be clear the game wasn't modded in the first place, everything being vanilla. I also did a clean reinstall just to be sure and it's still doing this (I'm using the original retail/disc copy). I also didn't change anything in the config files (both the LimitAdjuster or the LodLights). I even tested Sharptrails and ParticleEx and the game ran perfectly fine (I even checked if the error was documented on the speedrun.com forum and it isn't). Could it be because of the No-CD executable? I chose the gimpRus one because the one made by FairLight still has the CD check. I'll try it out and come back with an update if it solves the problem.

ThirteenAG commented 12 months ago

I just checked, and same happens to me. I think that's something latest ini fix commit was suppose to fix, but I don't remember if I uploaded new archives. Can you test zip from here? https://ci.appveyor.com/api/buildjobs/8yfbgap8qsx6xd95/artifacts/data%2FVC.Project2DFXv4.4.zip

MotorBoatMan commented 12 months ago

Unfortunately I'm getting the same issue but the weird thing is it took a couple seconds more this time (or so i think). I'll try to explain everything I did with as much detail as I can in case something helps, so here's what I did:

Now the way I test it is as follows:

That's all I can provide for atm, if there's something more I can help with let me know and thanks again for looking into this!

ThirteenAG commented 12 months ago

Well, it's something in limit adjuster probably.

MotorBoatMan commented 12 months ago

Just out of curiosity, does it crash for you when you use the new build you provided?

EDIT: The weird thing is that it feels just like the memory leaks from Manhunt (or so it seems for me).

ThirteenAG commented 12 months ago

In III.VC.SA.LimitAdjuster.ini delete StaticShadows = 8000 under [VCLIMITS]

MotorBoatMan commented 12 months ago

Tested both builds (the release and the provided build) for ~10 minutes and they work just fine now! Thanks a lot, I guess that solved the issue!

ThirteenAG commented 12 months ago

Yeah, I just saw a comment in limit adjuster that static shadows for iii/vc may not work. Strange that no one reported this before, since it essentially prevents everything from working.

MotorBoatMan commented 12 months ago

Yeah, I just saw a comment in limit adjuster that static shadows for iii/vc may not work. Strange that no one reported this before, since it essentially prevents everything from working.

Cool to know, especially since III doesn't suffer from this issue even with the static shadows.

MotorBoatMan commented 12 months ago

I retested it with FramerateVigilante as well and all works fine, I guess the issue has been solved.

ThirteenAG commented 12 months ago

I've reuploaded archives with edited ini.