search

ThirteenAG / WidescreenFixesPack

Plugins to make or improve widescreen resolutions support in games, add more features and fix bugs.
https://thirteenag.github.io/wfp
MIT License
2.35k stars 223 forks source link

Prostreet generic fix crash #1367

Closed Fizzsie closed 1 year ago

Fizzsie commented 1 year ago

This is caused by the "ImprovedGamepadSupport" and by the textures of the buttons? I am guessing cause when I do 3 no change the game launches fine but when I turn it to 1 or 2 the game crashes on start up. Any idea why this is happening?

xan1242 commented 1 year ago

Are the files buttons-playstation.tpk and buttons-xbox.tpk present in the scripts folder?

If not, you need to add them in from the release zip file. (We need to add a check for file existence, why is this not done yet?)

Fizzsie commented 1 year ago

Are the files buttons-playstation.tpk and buttons-xbox.tpk present in the scripts folder?

If not, you need to add them in from the release zip file. (We need to add a check for file existence, why is this not done yet?)

Yes they are

xan1242 commented 1 year ago

Ok, which version of the game are you running?

Fizzsie commented 1 year ago

1.1

xan1242 commented 1 year ago

Alrighty then.

Do the following:

  1. Open global.ini in the game root directory (create one if it doesn't exist)
  2. Under the [GlobalSets] key add DisableCrashDumps=0 (example: https://raw.githubusercontent.com/ThirteenAG/Ultimate-ASI-Loader/master/data/scripts/global.ini )
  3. Create a directory CrashDumps in the game root
  4. Launch the game with settings that crash it
  5. Upload the dumps it generates (both dmp and log) in a zip here
Fizzsie commented 1 year ago

I am either really stupid or no dumps are appearing

xan1242 commented 1 year ago

Is your game installed in Program Files? It could be it has no permissions to access it.

In which case - try running the game as Administrator and see if it resolves anything

Fizzsie commented 1 year ago

Crash dump.zip

xan1242 commented 1 year ago

I'm looking into this, but meanwhile I suggest you try my XtendedInput plugin instead:

https://github.com/xan1242/NFS-XtendedInput/releases/download/1.17/Release-ProStreet-Pack.zip

It is mostly feature complete for Pro Street, including ingame button remapping (which isn't on the others currently).

ImprovedGamepadSupport will be deprecated as soon as the ingame remap menu is complete.

xan1242 commented 1 year ago

NFSProStreet.GenericFix.asi.zip

Please test this ASI and see if it's not crashing anymore

Fizzsie commented 1 year ago

NFSProStreet.GenericFix.asi.zip

Please test this ASI and see if it's not crashing anymore

Still crashing

xan1242 commented 1 year ago

Can you send your exe over here?

If it's the vitality crack, then that might be the issue.

Fizzsie commented 1 year ago

nfs exe.zip

xan1242 commented 1 year ago

Yeah your EXE has the string swaps for the "SAAM" code patches. (this is something we or ExOpts could incorporate)

Otherwise it looks like the regular Battery EXE.

It seems to crash during bStringHash, it passes an invalid pointer and therefore it dies.

What other mods do you have installed in your game?

xan1242 commented 1 year ago

Actually, nevermind.

Please try using XtendedInput instead.

The problem is because of the implementation of ImprovedGamepadSupport being kinda wonky. The string pool pointers randomly got corrupted for you, which is why 3 works and 1 and 2 don't.

I'll polish up XtendedInput and this will be removed eventually anyway, so I don't see much point in wasting time investigating this problem.

xan1242 commented 1 year ago

ImproveGamepadSupport was deprecated for Pro Street as of: https://github.com/ThirteenAG/WidescreenFixesPack/pull/1381

Please use v1.18 or later builds of NFS_XtendedInput for Pro Street:

https://github.com/xan1242/NFS-XtendedInput/releases