ThirteenAG / WidescreenFixesPack

Plugins to make or improve widescreen resolutions support in games, add more features and fix bugs.
https://thirteenag.github.io/wfp
MIT License
2.26k stars 215 forks source link

[Issue] - Blacklist control scheme in Splinter Cell Conviction Fusion Mod #1586

Open Markie98 opened 1 month ago

Markie98 commented 1 month ago

So I've tested it a bit and here's what I found:

-Toggle aim became hold to aim (good to me personally) -Crouch is still a toggle (also good to me) -Run is still a toggle (bad to me - hold to run makes gameplay smoother; it's how it is in Blacklist as well) -You can no longer slide for some reason (run + hold crouch button) -You no longer roll either (crouch walk + tap cover button)

I feel like attempting to change crouch and cover behaviour has broken some stuff since those commands can also mix with other commands. The aim style change seems to work fine. If we could just have that and hold to run then it would be great already.

ThirteenAG commented 1 month ago

You can try checking blacklist.ini, and improve it. I had to disable slide so cover would work better, but maybe there's a way to make it work. Roll works on gamepad if you hold B. I don't plan to change run toggle, since it doesn't exist on gamepad.

Markie98 commented 1 month ago

I'll check that, thank you. Just noticed I forgot to mention the changed cover behaviour. Tested it a bit more and...

-Hold to cover became toggle cover (good to me), but it has issues: If you quickly press the cover button while also pressing some of the directional keys, the character might briefly stick to cover and then unstick from it by itself. And if you hold the cover button for a bit and release it instead of just pressing it, the behaviour will be as if it were still hold to cover. -Roll does indeed work on gamepad by holding the cover button, but it simply does not work on keyboard even if you're replicating the exact same input with the equivalent keys.

So basically for now you have to choose between the default control scheme or Blacklist's control scheme (hold to aim working fine + toggle cover with minor issues) but with slide removed and roll only working on gamepad.

r3538987 commented 1 month ago

So great that I checked an issue tab, and found out that there was update for Conviction. While running on KB is still toggle this could be nice future update, if possible. Gamepad controls are real nice and intuitive where with stick you can control player speed states. 👍

ThirteenAG commented 4 weeks ago

-Hold to cover became toggle cover (good to me), but it has issues: If you quickly press the cover button while also pressing some of the directional keys, the character might briefly stick to cover and then unstick from it by itself.

I released an update to make cover toggle a bit more reliable. From my brief testing, it works as intended now, and even compatible with slide.

-Roll does indeed work on gamepad by holding the cover button, but it simply does not work on keyboard even if you're replicating the exact same input with the equivalent keys.

There's nothing in my code that prevents roll on keyboard, but originally it's assigned on button press, when I switch it to hold for blacklist controls. It works for gamepad, and is much better for avoiding unintended rolling, but for some reason hold doesn't work with pc controls.

Markie98 commented 4 weeks ago

I released an update to make cover toggle a bit more reliable. From my brief testing, it works as intended now, and even compatible with slide.

Thank you, I will test it if I can and report issues if I find any.

There's nothing in my code that prevents roll on keyboard, but originally it's assigned on button press, when I switch it to hold for blacklist controls. It works for gamepad, and is much better for avoiding unintended rolling, but for some reason hold doesn't work with pc controls.

That's weird, unfortunate if we can't have roll on M&KB with the Blacklist controls scheme, but at least we have the other features.

ThirteenAG commented 4 weeks ago

Nah, slide works now, but roll doesn't. You can enable roll in the ini, if you switch HoldB to PressB for roll entries. On gamepad roll works by holding B. Also I restored slide when running and clicking crouch(LS).

Markie98 commented 4 weeks ago

Yeah I wrote slide instead of roll by accident, was just fixing it. So you mean if I change it back to press I can have it on keyboard? If so, problem solved then.

ThirteenAG commented 4 weeks ago

Yes, but I don't like that the player rolls after exiting cover sometimes. That's why I didn't make pressB for this scheme.

Markie98 commented 4 weeks ago

Good to know. Maybe this unintended behaviour won't happen or will happen less on M&KB? Either way it's good that there's a way to enable press to roll back for those that want the Blacklist control scheme but will still be using M&KB anyway, thanks.

ThirteenAG commented 4 weeks ago

Don't think so, since both roll and exit cover are tied to the same button. It would be tricky to work around as well.

r3538987 commented 4 weeks ago

You did mentioned that Death from above is also absent with this control scheme, any idea if workarounds are possible, or likely wont happen?

ThirteenAG commented 4 weeks ago

It's not absent, only the text prompt is not appearing(which is somewhat compensated by animation). I don't know the reason.

ThirteenAG commented 4 weeks ago

Though I suspect adding death from above by LT will make LT prompt appear, I didn't test that scenario. Can only assume it's also hardcoded somewhere in exe.

Markie98 commented 6 days ago

Apparently you also lose the ability to manually reload your weapon while holding a human shield when playing on mouse and keyboard with the Blacklist control scheme.

ThirteenAG commented 6 days ago

Have you tried to find a workaround by modifying ini?

Markie98 commented 6 days ago

You mean blacklist.ini? I did check it but I'm just not sure what I should change or how I should change it to fix things on M&KB. I'm not familiar with the parameters and everything seems to be written in controller commands rather than keyboard.