ThirteenAG / WidescreenFixesPack

Plugins to make or improve widescreen resolutions support in games, add more features and fix bugs.
https://thirteenag.github.io/wfp
MIT License
2.3k stars 221 forks source link

THPS4 Widescreen Patch basically crops #721

Open ENunn opened 5 years ago

ENunn commented 5 years ago

Guessing this is a bug? Desktop Screenshot 2019 09 03 - 22 14 04 62 Desktop Screenshot 2019 09 03 - 22 14 13 96 Desktop Screenshot 2019 09 03 - 22 14 24 05

ThirteenAG commented 5 years ago

Yes, it's a bug, I just don't know when I'll be able to take a look at it.

ghost commented 5 years ago

Looked at the source and I might know why, the correct aspect ratio the game is looking for isn't actually (ScreenX / ScreenY), as that produces a partially stretched in image, and a stretched in HUD. In my testing, 1.6f seems to match the Xbox version for 1080p at least. The FOV doesn't seem to be adjusting at all though. Played with an older version where the FOV fix worked and got it pretty close to the original XBOX.

Here's a video of this hack (can't open pull request because it uses code from 2015) running with FixHUD on. And here's a video of the XBOX version (HUD is always stretched at 720p on XB)

ThirteenAG commented 5 years ago

Xbox is not exactly known for it's stellar widescreen support, so I always match hud dimensions to 4:3 original image. It used to work, but I guess I broke it somewhere, need to take a look.

ghost commented 5 years ago

The PS2 & NGC version actually have a widescreen toggle that changes the aspect & FOV, but it does nothing when activated on PC. Since the game was ported to Xbox by Neversoft, it's presumed that it uses that same function for it's widescreen. It could be possible that the game uses a diff aspect for the HUD and the 3D world

ENunn commented 1 year ago

Hi, is there a fix for this yet? I installed the latest version and the issue still persists. Tried the developer build too and the same issue happens.