search

ThirteenAG / XboxRainDroplets

Enhanced implementation of xbox rain droplets from SkyGFX for other games.
MIT License
74 stars 5 forks source link

Rain droplets don't stop when game is paused #1

Closed AeroWidescreen closed 5 years ago

AeroWidescreen commented 5 years ago

I noticed that the animation does not stop when the game is paused. Would this be possible to fix? Carbon has an address (00A8AD18) that you could use for this.

Amazing mod btw. I didn't realize this existed for Carbon until now.

ThirteenAG commented 5 years ago

Yeah, I just didn't implement it, it needs a timestep address, like so: https://github.com/aap/skygfx_vc/blob/master/src/neoWaterdrops.cpp#L862 I maybe will add it later.

ThirteenAG commented 5 years ago

Okay, added (appveyor only for now). I also need to port it to MW, pretty sure everything should work identically there. In NFSU2 couldn't find how to check for rain, other than to use forced rain and check for that. And no idea if NFSU1 even has rain.

UPD. Uploaded to github, also updated MW, should work the same as carbon now.

AeroWidescreen commented 5 years ago

Nice, but I noticed that in Carbon the rain does not disappear when I go back to the frontend. This problem does not exist in Most Wanted based on my testing.

carbon

And no idea if NFSU1 even has rain.

It doesn't.

ThirteenAG commented 5 years ago

Should be fixed now.

AeroWidescreen commented 5 years ago

Confirmed, thanks.