ThirtyDegreesRay / OpenHub

An open source GitHub Android client app, faster and concise.
https://thirtydegreesray.github.io/OpenHub/
GNU General Public License v3.0
4.24k stars 415 forks source link

Hebrew Translation #5

Closed moriel5 closed 7 years ago

moriel5 commented 7 years ago

I have (sort of) finished translating OpenHub to hebrew (using Stringlate really helped me organize things towards the end). The possible oddity in the title is due to Stringlate forcing me to put %x in the title (I have no idea what will show up instead yet)

Issues:

  1. There a few lines (such as Theme Accent Color) that I may change after the next release, as I am not sure about the quality of my translation of those lines.

  2. I foresee issues with the lines "days ago", "hours ago", "minutes ago", and "seconds ago", since in hebrew the context is different (i.e. "5 minutes ago" becomes something like "before 5 minutes").

Update: I had fixed the oddities from the browser, "strings.xml" incoming. Update2: Here is the file, I had to archive it as GitHub would not allow me to upload .xml files.

he-IL.zip

ThirtyDegreesRay commented 7 years ago

Thanks, I have add Hebrew to OpenHub, but something strange, everything show as right-to-left from original left-to-right, is this normal?

Something wrong with uploading screenshots, I can't show you the screenshots. but I will release v1.2.1 tonight in Beijing time, you can download and experience it.

About your issues:

1.Okay, next time you can pull request to OpenHub, it's more convenient.

2.Thses line we can prefert later.

In a word, you experience v1.2.1 first, then we can perfect it if something was improper.

ThirtyDegreesRay commented 7 years ago

@moriel5 OpenHub v1.2.1 is released, enjoy it.

moriel5 commented 7 years ago

Thanks, I'll test it now. And about RTL, it's fine, hebrew is written from right to left.

Update: I have tested it and it is mostly good. There are a few issues with the translation, mainly the things I had brought up, however I'll have more time to deal with what I can after the holiday, so I should be available in under 36 hours.

I really like the fact that I can finally comment from OpenHub, however I hope that the next version will allow editing previous comments.

ThirtyDegreesRay commented 7 years ago

Okay, editing previous comments and some other functions about issues will allow next version.

moriel5 commented 7 years ago

Sorry about the lateness, I only recently came back from work (and this morning I had run out of battery).

That's great!

Now I only need two things to be able to completely move over to OpenHub: editing previous comments, and notifications (no need for system-wide notifications, though they would be nice, especially if they do not rely on Google's Play Services).

Regarding OpenHub, I can only wish you the best (and I'll translate to hebrew when I could).

By the way, when I had tried to post this from OpenHub, I only got an error that said "Page not found".

ThirtyDegreesRay commented 7 years ago

Sorry for my delay reply, I just come back from China National Holiday。

First, I will develop edit previous comments and add issue. Notifications will be develop latter.

I had received the error, I will fix it.

moriel5 commented 7 years ago

I'm glad to hear that.

I'll try asking a few friends of mine to help me out with the translations (no promises on what will happen, though), hopefully I'll be able to improve my translation (where linguistically possible).