search

Thiry1 / csgo-custom-hud

react.js based cs:go custom hud
15 stars 6 forks source link

Feature Request: Player images #21

Closed LukasW1337 closed 6 years ago

LukasW1337 commented 6 years ago

bd78d9e82313d1c55bcd203fb5251aee

Can we get an image for players like this? That would be really awesome!

Thiry1 commented 6 years ago

implemented via c1d21af044bafdd02039c411b9e2d64425c82285 . NOTE: You MUST set player image source to all players.

nppb commented 6 years ago

I recently tried this feature, thanks for implementing it (I didn't think I would like it that much!). I would suggest some ideas regardless. So at the moment the player picture will look like this: player_profile1 The picture needs a solid background and emulates the original webcam-style positioning. So if you switch to a player without picture the info bar will move ( I guess that's why you noted that every player needs an image).

First, I would suggest to add the option in playerInfo.ts to declare a default player image, like so: player_profile2 So whenever there is a player being spectated whose Steam-ID is not listed in playerInfo.ts he will get the default picture (But only if the user has specified a default picture).

In general, I would suggest, tho, to change the way this feature is placed since this is a picture and not a webcam. Maybe positioning for player pictures like the following might improve the look a little bit:

player_profile3

Even if this would only be optional to set (like playerPicTopPos="true" or something) I think it might get used quite a lot.

Thank you a lot for the effort you put in this project, I really appreciate your work.

Thiry1 commented 6 years ago

@nppb Thank you for suggestion.

I guess that's why you noted that every player needs an image

Correct. And I know this is not good for usability. So I will implement what your suggestion (default picture).

positioning for player pictures like the following might improve the look a little bit

Good idea.I will implement this 😄