search

Thiry1 / csgo-custom-hud

react.js based cs:go custom hud
15 stars 6 forks source link

Prefer fixed names from playerInfo.ts when setting up initial state. #32

Closed bergmannf closed 6 years ago

bergmannf commented 6 years ago

This is an initial fix for #29.

I am not very well-versed in react nor redux, so I feel that this might be a bit too hacky, by injecting it in the initial state, but it seems to work. Unfortunately it seems writing tests for this doesn't fit well with the testing model in the sagas.

I feel it would also be nicer if there were a way for users to change this information without having to recompile the entire project to get the changes to be picked up.

Thiry1 commented 6 years ago

I feel it would also be nicer if there were a way for users to change this information without having to recompile the entire project to get the changes to be picked up.

Agree.This project does not have any tests Because I made this project by rush work. If tests is available,we can compile partial of files and verify it. So I will be planned to add some tests to this project.