search

ThisIsLibra / AndroidProjectCreator

Convert an APK to an Android Studio Project using multiple open-source decompilers
https://maxkersten.nl/projects/androidprojectcreator/
GNU General Public License v3.0
368 stars 72 forks source link

Refactoring : Made a few changes with respect to principles of refactoring #27

Closed Ayushverma8 closed 2 years ago

Ayushverma8 commented 2 years ago

I did a couple of changes in the Classes to comply with the various refactoring techniques. Feel free to comment here or email on ayushverma8@outlook.com. I am more than happy to make changes w.r.t. to your requirements.

Cheers.

ThisIsLibra commented 2 years ago

Heya!

Thank you for the pull request submission. I have looked into the code, but I do not think the changes increase the code's readability much. An example is the archive extraction class, separating it from the file manager class. Whereas the extraction is different from the other functions within it, it does not necessarily break the "one responsibility per class" concept.

Overall, I think the code is more easily maintainable as it is right now, without the proposed changes. Sorry to be the bearer of bad news, and I truly appreciate the effort you put in. I hope this does not discourage you from future contributions to this projects, or others.

Stay safe out there, take care, and good luck in the future.

Cheers, Max

Ayushverma8 commented 2 years ago

Thanks Max. I appreciate your time and efforts in reviewing my code changes. I agree with your description. I'll refactor it more meaningfully next time.

Thanks again.