search

Thisarahetz / Calculator-Hacktoberfest2022

hackthoberfest2022
https://thisarahetz.github.io/Calculator-Hacktoberfest2022/
10 stars 22 forks source link

Improve how calculations are being done #31

Closed Saavrm26 closed 2 years ago

Saavrm26 commented 2 years ago

Use dedicated algorithm to calculate the string rather than using eval

Saavrm26 commented 2 years ago

May i be assigned to this issue

Thisarahetz commented 2 years ago

Shur. @Saavrm26 you can fix it

Saavrm26 commented 2 years ago

If this pr gets merged i'll add a documentation detailing how to add new functions to the calculator

Saavrm26 commented 2 years ago

This feature requires more testing, if there is any error in the calculations, let me know.

Saavrm26 commented 2 years ago

Should i raise another issue for the documentation? And should i close this issue