search

ThitipatC / pe

0 stars 0 forks source link

Error Message for non-existing tutorial tag when using available #5

Open ThitipatC opened 5 months ago

ThitipatC commented 5 months ago

Screen Shot 2567-04-19 at 17.07.23.png

nus-se-script commented 5 months ago

Team's Response

The same underlying mechanism as the one in as #5541 is responsible for this behaviour, where the specified Tutorial tag name is checked against the UniqueTutorialTagList.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error Message for non-existing tag when using tuttag del

Screen Shot 2567-04-19 at 16.40.22.png Screen Shot 2567-04-19 at 16.46.44.png

  • Personally, I felt like "Specified tutorial tag name does not exist in the tag list: THU10" is more precise than Specified tutorial tag name is not allowed: THU10.
  • By not allow, I does not clearly understand what is the exact problem.

[original: nus-cs2103-AY2324S2/pe-interim#5501] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Quoting the QnA for bug fix in PED

[Q6] Can we tweak UI text (i.e., error/help messages or other text shown to the user)? A: Only if the current text is incorrect (i.e., a bug). Adding more information or otherwise 'enhancing' the text is not allowed. Other points to note, ​ Making user-facing info more specific/informative (e.g., changing a generic error message Command format is invalid into a more specific error message The parameter p/ in the command is not valid) is an enhancement i.e., not allowed.

Given that the current error message of "Special tag name is not allowed" means the specified tag name cannot be used as a parameter to run the tuttag del command, it satisfies its purpose of getting the user to use other possible parameter names. Thus such an error message does not hinder the user and should just be considered a cosmetic bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]