search

ThizThizzyDizzy / nc-reactor-generator

A program to plan and generate reactors for Nuclearcraft (https://www.curseforge.com/minecraft/mc-mods/nuclearcraft-mod)
GNU General Public License v3.0
30 stars 6 forks source link

[Overhaul] Exported water recipe not recognized on import. #168

Closed CommanderLouiz closed 2 months ago

CommanderLouiz commented 2 months ago

Planner Version: NC-Reactor-Plannerator-5.0.0-beta.5

Default Nuclearcraft config

I noticed that both leu235.com and the planner export the "CoolantRecipeName" as "Water to whatever it gets turned into". However, when attempting to import into the Planner, this throws an IllegalArgumentException. Changing the string in the json to simply "Water" imports correctly.

Steps to Reproduce

  1. Load up an empty planner.
  2. Create a new overhaul reactor.
  3. Don't edit it at all, and export as json ("waterTest")
  4. Attempt to import that file.
  5. Get errored.

Here's the crash report. (It seems to be reporting my cpu as "amd64"? But mine is an intel chip.) crash-Thu Jul 04 23-43-12 CDT 2024.txt

CommanderLouiz commented 2 months ago

Ok, don't shoot me, but I just realized that the first json export is outdated, and that the last export option of NCPF (which makes a ncpf.json file) works correctly.

So of course the outdated export would make a file that doesn't import correctly. I guess the real issue here is that leu-235.com exports in an outdated format.

I'll go ahead and close this ticket...