search

ThizThizzyDizzy / nc-reactor-generator

A program to plan and generate reactors for Nuclearcraft (https://www.curseforge.com/minecraft/mc-mods/nuclearcraft-mod)
GNU General Public License v3.0
30 stars 6 forks source link

MSR Grouping Criticality is calculated wrong when grouped over multiple layers #44

Closed Thalzamar closed 3 years ago

Thalzamar commented 3 years ago

Please check if Criticality for grouped vessel is calculated right in this image i get 172 Flux for the cell which is times two 314 grafik but it calculates the criticality of the group as 102 (1 cell) instead of 204

massive design this is found in on layer 3 convert.zip because of that issue the reactor is supposed to work when it clearly shouldn't and is massivly overfluxed

ThizThizzyDizzy commented 3 years ago

The criticality of a vessel is not base fuel criticality*vessel size; it's instead multiplied by the surface factor (floor(open faces/6)) Since the 2-vessel bunches have 10 open faces, their surface factor is 1, and they have the same criticality as a lone vessel

Thalzamar commented 3 years ago

this makes no sense than why are 2 vessels that are next to each other handled different than when they are stacked ?

Thalzamar commented 3 years ago

because these 2 are next to each other and have crit if 204 grafik but if i stack them on top of each other instead they don't have that ?

ThizThizzyDizzy commented 3 years ago

I'm not quite sure what you mean; The vessel group in the image is a group of 4 vessels

Thalzamar commented 3 years ago

ok i seems to get it now 1 and 2 vessels count as 1 vessel while 3 and 4 vessels count as 2 this just feels wrong

Thalzamar commented 3 years ago

but eh exploiting this should be easy than

ThizThizzyDizzy commented 3 years ago

yeah, it's a bit wierd (the rounding down, specifically) It's what made the fractal-based vessel count challenge results happen :P