search

Thom1729 / Sublime-JS-Custom

Customizable JavaScript syntax highlighting for Sublime Text.
MIT License
137 stars 9 forks source link

Multi-line comment breaks highlighting #106

Closed jeremytm closed 3 years ago

jeremytm commented 3 years ago

Seems to be an error with general JS multi-line comments. This breaks DocBlockr code for example.

Using ST3, with JSCustom React syntax highlighting. This issue just appeared for me today, I assume after the latest update was installed.

image

Copy-pastable code

// Normal highlighting
let x = 1;

/***/ // Should be normal highlighting
let y = 1;
Thom1729 commented 3 years ago

I bet this is the same issue as https://github.com/babel/babel-sublime/issues/403. I solved it over there with an ad-hoc patch.

Whatever the problem was, it seems to be fixed on the latest dev build for ST4. I'm in the process of releasing a stable ST4 version; once that's done I might see about patching the ST3 branch.

Thom1729 commented 3 years ago

Actually, can you check what version you have installed? I just noticed that you said this was a new problem, but there shouldn't be any ST3-compatible updates — not in months.

jeremytm commented 3 years ago

Sublime Text 3.2.2 Build 3211

I'm not actually certain it was an update. I re-launched Sublime Text for the first time in a while today — but certainly not months since I last restarted my macbook.

I have JSCustom 3.0.1 installed image

Thom1729 commented 3 years ago

Version 3 is supposed to be exclusive to Sublime Text 4. Obviously, things went wrong. As an immediate fix, I've released v3.0.2, which should be identical to v2.4.2.

jeremytm commented 3 years ago

The issue is resolved now (after rebuilding syntaxes). Thanks!