search

Thom1729 / Sublime-JS-Custom

Customizable JavaScript syntax highlighting for Sublime Text.
MIT License
137 stars 9 forks source link

JSX Highlighting broken on 2.4.2/3.0.2 #109

Closed bcomnes closed 3 years ago

bcomnes commented 3 years ago

JSX highlighting working on 2.4.1:

Screen Shot 2021-04-21 at 10 08 39 AM

JSX Highlighting on 2.4.2/3.0.2

Screen Shot 2021-04-21 at 10 10 11 AM

Running sublime text 3211

Running this custom config:

{
  "configurations": {
        "Javascript Custom": {
          "jsx": true,
          "eslint_directives": true,
          "custom_templates": {
                "tags": {
                    "css": "scope:source.css",
                    "csjs": "scope:source.css",
                    "(s) => ":  "scope:source.css",
                    "html": "scope:text.html.basic",
                    "this.html": "scope:text.html.basic",
                },
                "comments": {
                  "GraphQL": "scope:source.graphql",
                  "gql": "scope:source.graphql"
                }
            }
        }
    }
}
bcomnes commented 3 years ago

Temporary work around:

Clone this repo into Sublime Text 3/Packages named as JSCustom and then check out tag v2.4.1. Restart Sublime text a few times when it asks you to.

Shelagh-Lewins commented 3 years ago

I'm seeing several issues with highlighting JSX files in JS Custom 3.0.2, Sublime Text 3 on Linux Mint.

JS Custom issues

  1. Closing curly bracket in pink
  2. MyView class name not highlighted
  3. Closing
tag and everything after it marked as string

I have no custom configuration and am running the Default theme.

Thom1729 commented 3 years ago

I've just released v3.0.3, which should be exactly identical to v2.4.1. This should resolve any remaining issues with the v3-on-ST3 comedy of errors.

bcomnes commented 3 years ago

Sweet thank you @Thom1729 ! Sublime text packaging is rough.

bcomnes commented 3 years ago

Closing

Thom1729 commented 3 years ago

@bcomnes Just to be sure, can you confirm that the problem is actually fixed?

bcomnes commented 3 years ago

v3.0.3 working on a local checkout. Tag is there, so its just a matter of waiting for PC to catch up.

bcomnes commented 3 years ago

v3.0.1 is still having syntax building issues (on local checkout) on sublime text 4.

zpetukhov commented 3 years ago

Hi to all. v3.0.3 fixed the issue for me. But today my ST3 has upgraded to v3.0.4. And JSX syntax is broken again. (Taking this opportunity: huge thanks for the package).

bcomnes commented 3 years ago

Latest version is working on Sublime text 4 as far as I can tell.

zpetukhov commented 3 years ago

Below are screenshots of 3.0.4, 3.0.3 and 3.0.2 in ST3. 3 0 4 3 0 3 3 0 2

Thom1729 commented 3 years ago

So it turns out I'm really bad at naming tags. I need to write a script for that rather than doing it manually.

v3.0.5 should fix everything. Please let me know if it does not.