Thom1729 / Sublime-JS-Custom

Customizable JavaScript syntax highlighting for Sublime Text.
MIT License
137 stars 9 forks source link

Syntax and commenting issues with TS Generics #126

Closed idr4n closed 3 years ago

idr4n commented 3 years ago

I just checked setting JSCustoms in tsx files. I'm getting the following with the default syntaxes that are installed when you install JSCustom:

The built-in JS-JSX-TS-TSX syntax that comes with ST4, based on initial trials, works as expected, that is, the new built-in syntaxes do proper commenting and uncommenting of JSX (they also remove the curly braces when uncommenting) as well as proper syntax even with TS generics such as React.FC<{...}>.

idr4n commented 3 years ago

Update: Actually, although I had reinstalled JSCustoms, the old syntaxes were still in my package folder 🤦🏻‍♂️. After rebuilding JS Custom syntaxes, I can say that they work as expected just like the ST4 built-in ones.

Thanks again!

idr4n commented 3 years ago

However, I would like to ask you, should I prefer ST4 built-in syntaxes over JSCustom or vice-versa?

Thom1729 commented 3 years ago

JS Custom is derived directly from the core syntaxes, and in such a way that I can keep it in sync with the core packages as they update. The only difference in behavior should be the configuration options you use. Therefore, the only reason to use JS Custom is if you use those options.