search

ThomDietrich / home-assistant-addons

AutoSSH Home Assistant Addon - alternative to cloud or VPN: Permanent port forwarding
MIT License
32 stars 18 forks source link

Add curl check of the local instance #16

Open hnykda opened 1 year ago

hnykda commented 1 year ago

@ThomDietrich WDYT so far? Something like this?

I was also thinking that a fancy way would be some kind of autodiscovery for beginners, e.g. using nmap, but that sounds too unreliable and probably not worth it.

ThomDietrich commented 1 year ago

Nice one! I've asked for a PR but didn't expect one within 24h :) Looks very good! I left a few comments.

hnykda commented 1 year ago

Can you resolve pending comments if they are OK please?

hnykda commented 1 year ago

FYI I haven't tested it yet, so keeping it in draft. Will try to test it when I am at home and can be sure I will not lock myself out :-D ...

Is changing https://github.com/hnykda/home-assistant-addons/blob/patch-1/repository.json#L2-L4 to something else, then adding it in https:///hassio/store as a new repo and then testing it enough?

ThomDietrich commented 8 months ago

Hey! Did you want to continue with this? I am looking forward to this improvement

hnykda commented 8 months ago

Hey! I am sorry, I haven't managed to get back to it, unfortunately 😞 . Hm, can you take it from me or is it unlikely?