ThomDietrich / home-assistant-addons

AutoSSH Home Assistant Addon - alternative to cloud or VPN: Permanent port forwarding
MIT License
32 stars 18 forks source link

Optional connection test #18

Closed firesoft-de closed 5 months ago

firesoft-de commented 5 months ago

Hello,

I use fail2ban in my setup to secure my SSH proxy. Unfortunately, the test connection of the plugin causes fail2ban to block my homeassistant server. For me, an optional connection test would be completely sufficient. Therefore, I have written a patch that gives the user a configuration option to disable the test. The test is enabled by default. If the user deactivates the connection test, they will be notified in the log.

Looking forward for feedback.

Thanks :)

ThomDietrich commented 5 months ago

Hey @firesoft-de, I see what you mean and why this is an issue. I've used the username "test" just to be explicit, however, I can't think of a reason why we should not simply use ${USERNAME} instead of "test" as the username. That should not change anything for existing users and will resolve your issue.

Correct?

firesoft-de commented 5 months ago

Perfect idea @ThomDietrich ! Thats a much simpler solution. Would fix my problem.

ThomDietrich commented 5 months ago

Great. You wanna update your PR?

Btw if you are in the flow, how about you look into this issue, I really don't have the headspace for it atm :D

17

firesoft-de commented 5 months ago

Done @ThomDietrich

ThomDietrich commented 5 months ago

Thank you :)