search

ThomDietrich / miflora-mqtt-daemon

Linux service to collect and transfer Xiaomi Mi Flora plant sensor data via MQTT to your smart home system, with cluster support 🌱🌼🥀🏡🌳
MIT License
610 stars 140 forks source link

Added support for Wiren Board MQTT Conventions #68

Closed aqualx closed 5 years ago

aqualx commented 5 years ago

Added support for Wiren Board controller that uses homeA-like MQTT conventions. This conventions are published here

ThomDietrich commented 5 years ago

I did not expect so many conventions when first developing this tool 😄 I'll soon switch to a class based structure for this. Would it be okay for you to check functionality then?

Your PR looks good to me. Thanks!

aqualx commented 5 years ago

I did not expect so many conventions when first developing this tool 😄 I'll soon switch to a class based structure for this. Would it be okay for you to check functionality then?

Your PR looks good to me. Thanks!

Of course it will not be a problem to test for me!

Thanks for nice daemon!

aqualx commented 5 years ago

I'll soon switch to a class based structure for this.

Maybe it is also good idea to implement support of other types of BLE sensors? Seems that this not a problem to add support for "Xiaomi Mi Temperature and Humidity Sensor" using library mitemp. I was almost going to extend your project with such support... But now, probably, I should wait till the end of your refactoring.

ThomDietrich commented 5 years ago

Valuable point. And yes I agree. Let's first refactor the code base. There are many things I've planned for the next version. Addition of other sensors will be much easier after that.

ThomDietrich commented 5 years ago

Thanks!